kelektiv/node-cron

"Error: WARNING: Date in past. Will never be fired." crash inside callback wrapper

Open

#813 opened on Dec 9, 2023

View on GitHub
 (15 comments) (1 reaction) (0 assignees)JavaScript (7,868 stars) (650 forks)batch import
help wantedstatus:waiting-on-response

Description

Description

I was using 2.2.0 but cross-checking the code with 3.1.6, this issue still exists.

I have a daily schedule to set up triggers for the day: https://github.com/Cyberbeni/node-red-contrib-cb-suncron/blob/3b3441c95a0fb4ab2356e906c810d3ef0e8de80f/src/SuncronLocation.ts#L29-L34

Setting up the jobs looks like this: https://github.com/Cyberbeni/node-red-contrib-cb-suncron/blob/3b3441c95a0fb4ab2356e906c810d3ef0e8de80f/src/Suncron.ts#L44-L59

I had this Node-RED crash today at the time that the cron job should have fired (and probably had multiple similar ones in the past as I had some skipped schedules):

9 Dec 15:49:24 - [red] Uncaught Exception:
9 Dec 15:49:24 - [error] Error: WARNING: Date in past. Will never be fired.
    at CT.sendAt (/data/node_modules/cron/lib/time.js:177:12)
    at CT.getTimeout (/data/node_modules/cron/lib/time.js:202:29)
    at Timeout.callbackWrapper [as _onTimeout] (/data/node_modules/cron/lib/job.js:141:36)
    at listOnTimeout (node:internal/timers:559:17)
    at processTimers (node:internal/timers:502:7)

Expected Behavior

If diff is more than 0 but newTimeout would be negative (because slow hardware or whatever), we shouldn't throw an error that can't be handled.

Actual Behavior

Occasional crash with the included call stack.

Possible Fix

Treat this.cronTime.getTimeout() throwing an error as if diff was not more than 0.

Steps to Reproduce

Remove if (diff > 0) check and insert a 1 second sleep before this line to imitate slow hardware:

https://github.com/kelektiv/node-cron/blob/d6143937d8774d8e4f5dcf3fcb86b296e2811c29/src/job.ts#L235

Then just setup a job with a single Date and an onTick callback.

Context

see description

Your Environment

  • cron version: 2.2.0
  • NodeJS version: nodered/node-red:2c51c6aaed04 docker container
  • Operating System and version: nodered/node-red:2c51c6aaed04 docker container
  • TypeScript version (if applicable): 4.9.5
  • Link to your project (if applicable): https://github.com/Cyberbeni/node-red-contrib-cb-suncron

Contributor guide

Tech stack
javascripttypescript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jscron concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The bug occurs in `src/job.ts` around line 141 where `callbackWrapper` calls `this.cronTime.getTimeout()` which throws 'Date in past' when the computed timeout is negative. The fix should wrap the `getTimeout()` call in a try catch and handle the error by treating it as if the timeout diff is not greater than 0. See the code in `src/time.js` line 177 for the throw source. The issue provides clear reproduction steps and expects to not crash when the timeout is negative.
"Error: WARNING: Date in past. Will never be fired." crash inside callback wrapper · kelektiv/node-cron#813 | Good First Issue