kelektiv/node-cron

refactor runtime check & typings of exclusive parameters timeZone & utcOffset

Open

#704 opened on Sep 30, 2023

View on GitHub
 (4 comments) (1 reaction) (0 assignees)JavaScript (650 forks)batch import
good first issuehacktoberfesthelp wantedstatus:readytype:refactor

Repository metrics

Stars
 (7,868 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Does it? First condition precludes the second

https://github.com/kelektiv/node-cron/blob/a7dee32091b91dcf465e67c32a57d66151b5a774/src/job.ts#L56 https://github.com/kelektiv/node-cron/blob/a7dee32091b91dcf465e67c32a57d66151b5a774/src/job.ts#L57

https://github.com/kelektiv/node-cron/blob/a7dee32091b91dcf465e67c32a57d66151b5a774/src/job.ts#L65

Contributor guide

Research direction
Review the conditional logic in src/job.ts lines 56-57 and 65, and ensure the exclusive validation between timeZone and utcOffset is correctly structured. Consider adding or updating type definitions to enforce exclusivity at compile time.
Tech stack
javascripttypescriptnodejs
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70