keithamus/jwerty

Key combo triggers on single key.

Open

#50 opened on Jun 28, 2014

View on GitHub
 (1 comment) (1 reaction) (1 assignee)JavaScript (1,214 stars) (117 forks)batch import
bughelp wanted

Description

Shouldn't this only trigger when both 'w' and 'e' are pressed? It triggers when 'w' is pressed.

jwerty.key('w+e', function () { console.log('w+e') });

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of JavaScript keyboard eventsfamiliarity with jwerty library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the key combo parsing in jwerty, specifically how the 'w+e' combination is registered. Look at the event listener binding and the logic that checks which keys are pressed. The issue likely lies in the combination detection code, where pressing 'w' alone fires the callback. Check the source file for key combo handling, possibly in jwerty.js, and examine the condition that should require both keys to be pressed simultaneously.