keithamus/jwerty

Key combo triggers on single key.

Open

#50 opened on Jun 28, 2014

View on GitHub
 (1 comment) (1 reaction) (1 assignee)JavaScript (117 forks)batch import
bughelp wanted

Repository metrics

Stars
 (1,214 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Shouldn't this only trigger when both 'w' and 'e' are pressed? It triggers when 'w' is pressed.

jwerty.key('w+e', function () { console.log('w+e') });

Contributor guide

Research direction
Examine the jwerty library's event handling logic for multi key combos. Trace how the 'w+e' combo is parsed and check the condition that triggers the callback. Look for missing checks for simultaneous keypresses.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75