keithamus/jwerty

Key binding not working on IE

Open

#5 opened on Oct 24, 2011

View on GitHub
 (15 comments) (0 reactions) (0 assignees)JavaScript (1,214 stars) (117 forks)batch import
bughelp wanted

Description

Hi,

First of all gratz for this awesome lib ! Nevertheless i cant make it work on internet explorer due to the event.metaKey property which is 'undefined' on IE. Thus each property in the jwertyCode object are not equals to those in the event object :

// For each property in the jwertyCode object, compare to `event`
for (var p in jwertyCode[n]) {
// ...except for jwertyCode.jwertyCombo...
 if (p !== 'jwertyCombo' && event[p] !== jwertyCode[n][p]) returnValue = false;
 }

I temporarily bypassed this IE problem by removing the metaKey references in your lib.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptbrowser events
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue is that `event.metaKey` is undefined in Internet Explorer, causing the property comparison loop to fail. The fix likely involves either adding a guard against undefined properties in the loop or removing `metaKey` from the event code object for IE. Look at the source code in the repository for the loop described in the issue and consider a conditional check. The comments may contain additional context or suggested fixes.