keithamus/jwerty

jwerty.is() not working in FF

Open

#38 opened on Jul 10, 2013

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,214 stars) (117 forks)batch import
help wanted

Description

// For each property in the jwertyCode object, compare to `event`
for (var p in jwertyCode[n]) {
    // ...except for jwertyCode.jwertyCombo...
    if (p !== 'jwertyCombo' && event[p] != jwertyCode[n][p]) returnValue = false;
}

I'm trying to check for key binding when clicking on an element but jwerty.is() does return false for 'shift', 'cmd' & 'alt'. After some minutes of debugging I've found the problem: You're getting the originalEvent which is in that case [object MouseEvent] and has no property keyCode for that reason. Therefore the result is always false. I'm not sure if there is a solution for this problem in FF, but it is working fine in Chrome. Thanks for this wonderful library!

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of DOM eventsKnowledge of cross browser event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue is that jwerty.is() fails in Firefox when a MouseEvent is passed instead of a KeyboardEvent because MouseEvent lacks keyCode. To fix, check the event type (event.type) and handle accordingly. Look at how jwerty internally uses jwertyCode and consider using event.key or event.which as fallbacks. Reference the Mozilla Developer Network for event handling differences.