kedacore/keda

Hashicorp vault auth allow tokens directly set in TriggerAuthentication

Open

#6,026 opened on Aug 2, 2024

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Go (1,457 forks)auto 404
authbuggood first issuehelp wantedsecurity

Repository metrics

Stars
 (10,372 stars)
PR merge metrics
 (PR metrics pending)

Description

Report

Currently, hashicorp vault auth supports 2 login methods, one based on service account and other based on tokens. The problem is that the token isn't provided from a secret but from the TriggerAuthentication directly. This is a security risk as TriggerAuthentication isn't a sensitive API by design: image image

Expected Behavior

The token should be recovered from a secret

Actual Behavior

The token is read from the TriggerAuthentication manifest

Contributor guide

Research direction
Modify the Vault authentication provider to read the token from a Kubernetes secret instead of from the TriggerAuthentication manifest. Update the relevant controller and documentation to reflect this change.
Tech stack
go
Domain
backendinfrastructuresecurity
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
KubernetesVaultKEDA concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50