kedacore/keda

Refactor and optimize the fallback logic

Open

#5,359 opened on Jan 10, 2024

View on GitHubContributor guide
 (3 comments) (1 reaction) (0 assignees)Go (1,457 forks)auto 404
help wantedstale-bot-ignore

Repository metrics

Stars
 (10,372 stars)
PR merge metrics
 (PR metrics pending)

Description

Proposal

Before we support parallel request for metrics, we calculated the fallback one by one after each metrics.

After supporting the parallel requesting, we are using the same fallback approach just iterating over all the metrics sequentially to calculate the fallback. As now we have all the info to calculate the fallback with all the metrics at once, we should optimice this process, reducing also the underlying request to k8s api

Contributor guide

Research direction
Examine the current fallback logic that iterates over metrics sequentially, and refactor it to compute fallback using all collected metrics simultaneously, reducing Kubernetes API calls.
Tech stack
go
Domain
backendinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoKubernetes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70