kedacore/keda

Add a comment once e2e finishes

Open

#5,308 opened on Dec 21, 2023

View on GitHubContributor guide
 (13 comments) (0 reactions) (0 assignees)Go (1,457 forks)auto 404
feature-requesthelp wantedstale-bot-ignoretesting

Repository metrics

Stars
 (10,372 stars)
PR merge metrics
 (PR metrics pending)

Description

Proposal

In order to be able to tell which e2e test run has passed, we should generate a new comment instead of just adding an emoji to the original comment (the one with /run-e2e command). The new comment should quote the original comment so we have a reference.

The benefit is, that we get a notification that e2e test run has finished, so we can check the results.

Old Proposal (we don't want to go this direction)

In order to be able to tell which PR is ready for final review/merge, it would be nice if a label (eg e2e-passed) could be added to the PR.

If the there are additional commits/pushes to the PR, the label should be automatically removed.

Contributor guide

Research direction
Examine the current e2e workflow and comment mechanism, then implement a function to post a new comment quoting the original /run e2e command.
Tech stack
go
Domain
backenddevopstesting
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGitHub Actions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70