kazupon/vue-i18n

silentFallbackWarn does not silent linked locale messages fallback warn

Open

#933 opened on Jul 13, 2020

View on GitHub
 (1 comment) (6 reactions) (0 assignees)JavaScript (7,181 stars) (886 forks)batch import
Type: Bughelp wanted

Description

vue & vue-i18n version

vue-i18n v8.18.2 Vue.js v2.6.11

Reproduction Link

https://jsfiddle.net/Lt4vp8x0/

Steps to reproduce

Have a sub-component that implements component based localization. Turn silentFallbackWarn to true, and run the fiddle.

You should see in the console that vue-i18n is still giving out warnings, but, as the tests states: https://github.com/kazupon/vue-i18n/blob/f42e81f65a88eeeccc311b970d2d4fd4181712ed/test/unit/silent.test.js#L93-L114, I should not do it.

What is Expected?

No fallback warnings, there are even tests for this behavior: https://github.com/kazupon/vue-i18n/blob/f42e81f65a88eeeccc311b970d2d4fd4181712ed/test/unit/silent.test.js#L93-L114, I should not do it.

What is actually happening?

I'm seeing fallback warn messages.

Contributor guide

Tech stack
javascriptvue
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Vue.jsBasic understanding of vue i18n
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the warning logic in the vue i18n source code, particularly the handling of silentFallbackWarn. The test file at test/unit/silent.test.js lines 93-114 shows expected behavior. The fix likely involves ensuring that when silentFallbackWarn is true, warn messages for linked locale messages in component based localization are suppressed. Examine the warning function in src/ and the component localization code to identify where the fallback warning is emitted unconditionally.