kazupon/vue-i18n

Custom Formatter Example is broken

Open

#825 opened on Mar 30, 2020

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (7,181 stars) (886 forks)batch import
Type: Examplehelp wanted

Description

https://github.com/kazupon/vue-i18n/blob/f2b8a1024d8a0772ada501f5eac21d0471b0a35d/examples/formatting/custom/src/formatter.js#L52

TypeError: fn(...).map is not a function

Still investigating how to solve this properly (not using legacy places). Trying to support a %replacement% instead/aside of the curly braces.

Any helpful insight and fixing the example would be appreciated!

Contributor guide

Tech stack
vuejavascript
Domain
frontendinternationalization
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Knowledge of Vue.jsFamiliarity with vue i18nUnderstanding of JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the custom formatter example at the linked file (examples/formatting/custom/src/formatter.js line 52). Understand the expected behavior of Vue i18n custom formatters and the legacy places API. The issue reports a TypeError indicating that the return value of the formatter function is not an array, so adjust the formatter to return an array of strings. Confirm the fix works with the example's usage.