kazupon/vue-i18n

Memory Leak SSR

Open

#589 opened on May 27, 2019

View on GitHub
 (15 comments) (1 reaction) (0 assignees)JavaScript (7,181 stars) (886 forks)batch import
Status: PR WelcomeType: Bughelp wanted

Description

vue & vue-i18n version

vue-i18n v8.11.2

Reproduction Link

any SSR usage

Question

In line https://github.com/kazupon/vue-i18n/blob/master/src/mixin.js#L58 a new object is created server-side because we are in beforeCreate. This is necessary to get the languages rendered server-side as far as I can see but at the same time it generates a memory leak because the destructor is not called by SSR. Do you have any ideas how to overcome this issue?

Contributor guide

Tech stack
vuejavascriptnodejs
Domain
backendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Vue.js basicsSSR understandingMemory leak awareness
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the mixin.js file at line 58 (https://github.com/kazupon/vue i18n/blob/master/src/mixin.js#L58). Look into how the 'beforeCreate' hook creates new objects server side causing memory leaks, as the destructor is not called. Propose a solution that either avoids creating these objects during SSR or ensures proper cleanup. Consider using a WeakMap or a server side cache that gets cleared after rendering.