karma-runner/karma

script-launcher : bad script browser recognition

Open

#754 opened on Sep 23, 2013

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (11,918 stars) (1,703 forks)batch import
help wantedtype: backlogtype: feature

Description

Hi all, just wanted to note that after updating to latest karma (0.10.2) , if someone's got problem with "script browsers" ( we use a .bat to run IE tester with specific IE versions) , it could be because of the "browser type recognition". It gets recognized as "script browser" only if it's path it's absolute

lib\launcher.js line 19

 // TODO(vojta): determine script from name
      if (name.indexOf('/') !== -1) {
        name = 'Script';
      }

we just put a temporary work-around like this

 // TODO(vojta): determine script from name
      if (name.indexOf('/') !== -1  || name.indexOf('.bat') !== -1) {
        name = 'Script';
      }

Contributor guide

Tech stack
javascriptnodejs
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is in lib/launcher.js line 19. The fix involves adding an additional condition to detect script browsers by checking for '.bat' extension in addition to absolute path. The workaround provided in the issue shows the exact change needed. No further investigation required; the fix is localized and straightforward.