karma-runner/karma

Remove unnecesary stat of watched files

Open

#469 opened on Apr 6, 2013

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (11,918 stars) (1,703 forks)batch import
help wantedtype: refactor

Description

chokidar is passing the stat now, since https://github.com/paulmillr/chokidar/commit/a8c2328f376802d9c0f7cf221013704bf5a2e369

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Node.jsknowledge of file watching
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Look at the karma source code for where it uses chokidar's watch method. The referenced commit (https://github.com/paulmillr/chokidar/commit/a8c2328f376802d9c0f7cf221013704bf5a2e369) shows chokidar now provides stat information. Find where karma is calling stat separately and remove that call. Ensure the tests still pass. The change is localized and well defined.