karma-runner/karma

Batch job does not terminate with Karma 1.4.0

Open

#2552 opened on Jan 27, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (11,918 stars) (1,703 forks)batch import
help wantedneeds: investigationtype: bug

Description

Expected behaviour

The batch job gulp test_browser should terminate when the Gulp task test_browser finishes.

Actual behaviour

The batch job gulp test_browser does not terminate when the Gulp task test_browser finishes. I need to kill the job manually (Ctrl + C).

Environment Details

  • Operating system: Windows 10 Home
  • Karma version (output of karma --version): 1.4.0

gulpfile.js

gulp.task('test_browser', function(done) {
  gutil.log(gutil.colors.yellow('Running tests in Google Chrome:'));

  var server = new Server({
    configFile: __dirname + '/karma.conf.js',
    files: [
      'test/js/helpers/**/*.js',
      paths.dist_window + '/**/*.js',
      'test/js/specs/**/*Spec.js'
    ]
  }, done);

  server.start();
});

Steps to reproduce the behaviour

  1. I upgraded from "karma": "1.3.0" to "karma": "1.4.0" (in package.json)
  2. When I run gulp test_browser, then this job does not terminate with Karma 1.4.0 (but it does with Karma 1.3.0)
  3. The project I used for testing is: https://github.com/wireapp/bazinga64

Terminal output with Karma v1.3.0 server

karma-1-3-0

Terminal output with Karma v1.4.0 server

karma-1-4-0

Please let me know if you need more details. Happy to help!

Contributor guide

Tech stack
javascriptnodejs
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of KarmaFamiliarity with GulpNode.js debugging skills
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Karma server lifecycle changes between versions 1.3.0 and 1.4.0. The issue is that the batch job does not terminate when using Karma 1.4.0, suggesting that the `done` callback in the Gulp task is not being invoked. Look at the Karma changelog and compare source code for `Server` class, especially the `start` method and how it calls the callback. The repository wireapp/bazinga64 may be used for reproduction. Examine PRs or commits around version 1.4.0 for changes to server termination logic.