karma-runner/karma

Find replacement for DI

Open

#2475 opened on Nov 28, 2016

View on GitHub
 (11 comments) (2 reactions) (0 assignees)JavaScript (11,918 stars) (1,703 forks)batch import
discusshelp wantedtype: refactor

Description

The di (dependency injection) module we currently use is very outdated and the di setup we have is pretty hard to understand, especially for people new to the code base.

Currently all plugins though depend on it, so we need to find a backwards compatible solution or at least an interface that is as simple to use as the current one for plugin authors.

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Karma plugin systemJavaScriptNode.jsDependency injection concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the current DI module in the lib/di directory of the karma repository. Look at how plugins register and consume services. Research alternative DI libraries like awilix, tsyringe, or inversify, evaluating them for backwards compatibility and simplicity. Also consider a custom lightweight DI container to minimize breaking changes. Review issue comments for any prior discussion on potential solutions.