karma-runner/karma

Using autoWatch with a **/* glob doesn't update the reports

Open

#2203 opened on Jun 27, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (11,918 stars) (1,703 forks)batch import
help wantedtype: bug

Description

Expected behavior

autoWatch should work and report correct results with glob matchers of src/app/**/*.js

Actual behavior

Reports are not updating to the correct result in autoWatch when using a matcher like src/app/**/*.js

Enviroment Details

  • Karma version (output of karma --version): 1.1.0
  • Relevant part of your karma.config.js file files

Steps to reproduce the behaviour

I've prepared an example project at - https://github.com/shairez/karma-autowatch-problem-example

  • Before going through the steps below, clone the project

Here are the steps:

  1. karma start
  2. Verify that you see the Executed 1 of 1 SUCCESS message
  3. Go to registration.component.spec.js
  4. On line 25 change ctrl.createAccount() to ctrl.createAccount2()
  5. You should see a failing test message in the karma report, but you see the same SUCCESS message from before

It is solved when you change the glob matcher

I managed to find out that it's got to do with the glob matcher in the files configuration in karma.conf.js.

  1. Go to karma.conf.js,
  2. Comment line 12 where it says 'src/app/**/*.js'
  3. Uncomment line 13 where it says 'src/app/**/*.{component,service}.js'
  4. You should now see the autoWatch works correctly

Bottom line

Something with 'src/app/**/*.js' breaks the autoWatch reporting behavior

Contributor guide

Tech stack
javascriptnodejs
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsKarma configuration basicsUnderstanding of glob patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the glob pattern handling in Karma's file watching logic. The issue provides a reproduction repository at https://github.com/shairez/karma autowatch problem example. Focus on the `karma.conf.js` file where changing the glob from `'src/app/**/*.js'` to a more specific pattern resolves the issue. Look at how Karma processes file patterns in the watcher (likely in the `file list.js` or `watcher.js` files). Check if there is a regex or string comparison issue with double asterisk patterns.