kanisterio/kanister

Enable linters for test packages

Open

#2,962 opened on Jun 26, 2024

View on GitHub
 (10 comments) (1 reaction) (1 assignee)Go (178 forks)auto 404
acceptedgood first issue

Repository metrics

Stars
 (883 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe. As of now linters are disabled from test packages in .golangci.yaml file:

issues:
  exclude-rules:
    - path: '_test.go'
      linters:
        - errcheck                      # Errors may be ignored in tests.
        - unparam                       # Tests might have unused function parameters.
        - lll
        - dupl
        - misspell
        - nestif
        - gci

Describe the solution you'd like After enabling this linter, fix all kind of linter issues coming up in test packages.

Contributor guide

Research direction
Read the .golangci.yaml file to understand the current linter exclusions. Enable the linters by removing the exclude rules for test files. Run `golangci lint run ./...` to see the issues. Fix each issue according to the linter's guidance. Start with simple linters like `misspell` or `gci` if new to the project.
Tech stack
go
Domain
backendtestingdevops
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go.golangci.yamllinters
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60