kaldi-asr/kaldi

"bc" is not linux native , you should add some check

Open

#2,954 opened on Dec 31, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Shell (15,392 stars) (5,359 forks)batch import
enhancementhelp wantedstale

Description

low priority issue , it is not a real issue to debug this error , and install bc afterwards , but nevertheless , this is not a native linux command . you should add some warning in , maybe in run.sh for all the diarizations recipe , or in the script itself.

https://github.com/kaldi-asr/kaldi/blob/3e77220b3297831c3a370169580b880461897682/egs/callhome_diarization/v1/diarization/extract_ivectors.sh#L95

Contributor guide

Tech stack
shell
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic shell scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue requests adding a check for the 'bc' command in the shell scripts, specifically in the file `egs/callhome diarization/v1/diarization/extract ivectors.sh`. Look at line 95 where 'bc' is used. Add a check at the beginning of the script using `command v bc` or similar to verify bc is installed. If not, print a warning and exit or install it. Consider also checking other scripts in the same recipe. The maintainers have not responded, so the fix is open for contribution.
"bc" is not linux native , you should add some check · kaldi-asr/kaldi#2954 | Good First Issue