kaldi-asr/kaldi

Fix registering of CuAllocatorOptions

Open

#2,929 opened on Dec 21, 2018

View on GitHub
 (6 comments) (0 reactions) (1 assignee)Shell (15,392 stars) (5,359 forks)batch import
bughelp wantedstale

Description

Currently it seems we register the global options but don't call the SetOptions() function. There is no need for the global options-class variable, we can use a local one in each binary that registers the options. @desh2608 can you please do this? Ask one of the other students if you don't know how.

Contributor guide

Tech stack
cppshell
Domain
backendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++Kaldi framework
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is about fixing the registration of CuAllocatorOptions. The current code registers global options but does not call SetOptions(). The fix is to remove the global variable and use a local CuAllocatorOptions instance in each binary that registers options, then call SetOptions(). The relevant code is likely in the Kaldi source where CuAllocatorOptions is defined. Check comments from maintainer @desh2608 for further guidance. No linked PRs exist.