kaldi-asr/kaldi

Fix registering of CuAllocatorOptions

Open

#2,929 opened on Dec 21, 2018

View on GitHub
 (6 comments) (0 reactions) (1 assignee)Shell (5,359 forks)batch import
bughelp wantedstale

Repository metrics

Stars
 (15,392 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently it seems we register the global options but don't call the SetOptions() function. There is no need for the global options-class variable, we can use a local one in each binary that registers the options. @desh2608 can you please do this? Ask one of the other students if you don't know how.

Contributor guide

Research direction
Investigate the CuAllocatorOptions registration mechanism, remove the global options class variable, and ensure SetOptions() is called appropriately in each binary.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60