kaizendorks/pymongo_inmemory

Update testing GitHub Action to check for differences in poetry.lock

Open

#26 opened on May 31, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (18 forks)auto 404
good first issuetesting

Repository metrics

Stars
 (53 stars)
PR merge metrics
 (PR metrics pending)

Description

It is easy to forget to update poetry.lock file after changing something in the pyproject.toml file. There should be a step in testing workflow that

  1. Gets a hash of the lock file right after the checkout and saves into an environment variable
  2. Runs poetry update
  3. Gets the hash again and compares with the previous hash
  4. If results are different, then breaks the workflow.

Acceptance Criteria

  • Steps to verify correctness of poetry.lock file is added to testing GitHub Action

Contributor guide

Research direction
Add a step in the testing GitHub Action workflow that computes a hash of poetry.lock after checkout, runs 'poetry lock no update', then computes the hash again and compares. If different, fail the workflow. Reference GitHub Actions documentation for steps and shell commands.
Tech stack
python
Domain
devopsci cd
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGitHub ActionsPoetry
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60