justadudewhohacks/face-api.js

FaceLandmarks68: left and right eyes/brows are reversed.

Open

#222 opened on Feb 21, 2019

View on GitHub
 (10 comments) (0 reactions) (0 assignees)TypeScript (15,839 stars) (3,649 forks)batch import
buggood first issuehelp wanted

Description

Hello,

FaceLandmarks68.getLeftEye() returns points corresponding to the right eye, and FaceLandmarks68.getRightEye() returns points corresponding to the left eye. Same issue for the FaceLandmarks68.getLeftEyeBrow() and FaceLandmarks68.getRightEyeBrow().

Contributor guide

Tech stack
typescripttensorflowjavascript
Domain
machine learningfull stack
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic TypeScriptknowledge of face landmarks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Examine the FaceLandmarks68 class definition, likely in src/faceLandmarksNet/FaceLandmarks68.ts. Compare the landmark indices used in getLeftEye() and getRightEye() with the standard 68 point facial landmark mapping. The bug suggests that the left and right eye indices are swapped. A similar swap likely exists for eyebrows. The fix involves swapping the returned arrays or adjusting the index constants. Look at the issue comments for any discussion about the expected indices, and verify against the original paper or training data.