juspay/hyperswitch

[REFACTOR] Move Hardcoded Value to Constant for Max Invitations

Open

#5,938 opened on Sep 18, 2024

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Rust (42,690 stars) (4,676 forks)batch import
A-usersC-refactorgood first issuehacktoberfest

Description

Feature Description

Here: https://github.com/juspay/hyperswitch/blob/407be56ed368d543b440bfffa6704518e487dced/crates/router/src/core/user.rs#L643

In the current implementation, the value 10 is hardcoded when checking the number of invite requests in the code. To improve maintainability and avoid magic numbers, this value should be moved to a constant in crates/router/src/consts/user.rs.

Possible Implementation

  • Create a new constant in crates/router/src/consts/user.rs to represent the maximum number of allowed invite requests.
  • Refactor the code to replace the hardcoded value 10 with this new constant.

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Submission Process:

  • Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
  • Once assigned, submit a pull request (PR).
  • Maintainers will review and provide feedback, if any.
  • Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

Contributor guide

Tech stack
rust
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Rust syntaxFamiliarity with constants in Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Locate the file crates/router/src/core/user.rs at line 643 (or search for the hardcoded value 10). Also check crates/router/src/consts/user.rs for existing constants. Create a new constant for max invitations, then replace the hardcoded value. Ensure the constant is exported if needed. Reference the linked line and similar constants in the consts file.