juspay/hyperswitch

[REFACTOR] Use `MerchantJwtWithProfileId` instead of `MerchantJwt` in Authentication data

Open

#5,937 opened on Sep 18, 2024

View on GitHub
 (13 comments) (0 reactions) (1 assignee)Rust (42,690 stars) (4,676 forks)batch import
A-usersC-refactorgood first issuehacktoberfest

Description

Feature Description

We have introduced MerchantJwtWithProfileId to the AuthenticationData enum. The new variant includes both a profile_id and a non-optional user_id field, improving upon the older MerchantJwt variant. The goal of this issue is to replace all instances of MerchantJwt with MerchantJwtWithProfileId.

You can find the location of MerchantJwt here: https://github.com/juspay/hyperswitch/blob/1ff66a720b29a169870b2141e6ffd585b4d5b640/crates/router/src/services/authentication.rs#L128 MerchantJwtWithProfileId is located just under it.

Possible Implementation

  • Refactor the existing codebase to replace occurrences of MerchantJwt with MerchantJwtWithProfileId.
  • Ensure that merchant_id, user_id, and profile_id (where necessary) are properly handled in the updated variant.

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Submission Process:

  • Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
  • Once assigned, submit a pull request (PR).
  • Maintainers will review and provide feedback, if any.
  • Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

Contributor guide

Tech stack
rust
Domain
backendauthentication
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Rust knowledgefamiliarity with enum variants
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
First, locate the `MerchantJwt` variant in `crates/router/src/services/authentication.rs` around line 128. Then search for all occurrences of `MerchantJwt` across the codebase. Replace each with `MerchantJwtWithProfileId`, ensuring that the required fields (profile id, non optional user id) are provided. Confirm that the new variant's constructor is used correctly. Check that the `authentication.rs` file compiles and that related tests pass. No linked PRs or further comments clarify specific edge cases; consider checking the enum definition and its usage in other modules.
[REFACTOR] Use `MerchantJwtWithProfileId` instead of `MerchantJwt` in Authentication data · juspay/hyperswitch#5937 | Good First Issue