juspay/hyperswitch

[BUG] 5xx while parsing `Evidence Type` in Disputes Attach Evidence file upload flow

Open

#3,489 opened on Jan 30, 2024

View on GitHub
 (3 comments) (0 reactions) (2 assignees)Rust (42,690 stars) (4,676 forks)batch import
A-coreC-buggood first issue

Description

Bug Description

5xx while parsing Evidence Type in Disputes File upload flow

Expected Behavior

It should have been a Bad request, telling Invalid Evidence Type

Actual Behavior

We are throwing 5xx

Steps To Reproduce

Provide an invalid evidence_type while doing File upload in Dispute Attach Evidence flow

Have you spent some time checking if this bug has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

None

Contributor guide

Tech stack
rust
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic Rust knowledgeHTTP request handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the dispute file upload endpoint, likely in a handler file under `crates/router/src/routes/disputes.rs` or similar. Look for parsing of `Evidence Type` and ensure invalid input returns a 400 error instead of causing a panic or unhandled error. Check existing validation logic and consider using `error stack` or `Result` types properly.