juspay/hyperswitch

[REFACTOR]: [Coinbase] MCA metadata validation

Open

#2,901 opened on Nov 17, 2023

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Rust (42,690 stars) (4,676 forks)batch import
A-connector-integrationC-refactorgood first issuehelp wanted

Description

:memo: Feature Description

  • We don't have validation for MCA metadata, So while creating MCA we are allowing any json value. Because of which RequestEncodingFailure happening during payments for the MCA which doesn't have the expected fields

:hammer: Possible Implementation

  • While adding Merchant Connector Account we want that metadata field should be validated.
  • You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/2746 :bookmark: Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/coinbase and crates/router/src/core/admin.rs

:package: Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

:sparkles: Are you willing to submit a PR?

Contributor guide

Tech stack
rustrest api
Domain
backendapi
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust basicsCoinbase connectorReference PR #2746
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the referenced PR #2746 to understand how MCA metadata validation was implemented for other connectors. Then, implement similar validation logic in the Coinbase connector files in `crates/router/src/connector/coinbase` and adjust the admin core in `crates/router/src/core/admin.rs`. Ensure that the metadata field is validated when creating a Merchant Connector Account.