juspay/hyperswitch

[REFACTOR] : [Payme] Error Message For Connector Implementation

Open

#2,857 opened on Nov 13, 2023

View on GitHub
 (12 comments) (0 reactions) (1 assignee)Rust (42,690 stars) (4,676 forks)batch import
A-connector-integrationC-refactorgood first issuehelp wanted

Description

:memo: Feature Description

  • In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation.

:hammer: Possible Implementation

  • In order to manage payment methods that are not implemented by Hyperswitch or yet to be implemented, the connector transformers file should make use of the NotImplemented ConnectorError enum variant.
  • By doing so, we will throw same error message for all the Connector Implementation
  • You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/2831

:bookmark: Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

:package: Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

:sparkles: Are you willing to submit a PR?

Contributor guide

Tech stack
rustrest api
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of Rustunderstanding of Hyperswitch connector structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
The issue requires changing error messages in connector implementations to use the NotImplemented enum variant from ConnectorError. Refer to the linked PR #2831 for the expected pattern. All changes should be within `hyperswitch/crates/router/src/connector/`. Examine existing connectors to identify where 'not supported' messages are thrown and replace them with `Err(ConnectorError::NotImplemented(...))`.