juspay/hyperswitch

[BUG]: Remove Basic keyword from shift4 API key

Open

#1,438 opened on Jun 14, 2023

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Rust (42,690 stars) (4,676 forks)batch import
C-bugE-easyS-awaiting-triagegood first issue

Description

Bug Description

While accepting api_key from user in shift4 currently we accept something like Basic c2tfdGVzdF93cjhMYjdqd1FvbwajkhfbQ6.

This Basic Keyword should not be there as if we only want to access the value of the key at some other authorization it would be difficult to extract.

Expected Behavior

The Basic key should be appended in the code like it is done for Bluesnap in bluesnap.rs .

Since we add Basic at code level we can only expect the actual key in the input from the user, rather than expecting the Basic key along with it.

Actual Behavior

Basic as keyword needs to be added in the api_key field under connector_account_details in create connector account api

Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

No, but I'm happy to collaborate on a PR with someone else

Contributor guide

Tech stack
rustrest api
Domain
backendapipayments
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust basicsPayment connector architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue is to remove the 'Basic' keyword from the user provided Shift4 API key and append it in code, similar to how Bluesnap handles it in `bluesnap.rs`. Look at the Shift4 connector implementation to find where the key is accepted and modified. The fix involves stripping 'Basic' from the input and adding it during authorization header construction. Reference the `bluesnap.rs` file for the pattern.