juspay/hyperswitch

[FEATURE] unite payment intent and setup intent in stripe compatibility

Open

#1,242 opened on May 23, 2023

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Rust (42,690 stars) (4,676 forks)batch import
C-featuregood first issue

Description

Feature Description

There are some common fields in payment intent request and setup intent request .Adding any new common fields need to be added in both. So it is better to have a common struct and the common struct can be used in the individual struct. The common struct can be setup intent as well since setup intent request is a subset of payment intent request.

Possible Implementation

Create a separate struct with common fields or use setup intent in payment intent struct using serde flatten.

Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

No, but I'm happy to collaborate on a PR with someone else

Contributor guide

Tech stack
rust
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust basicsserde
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look at the existing PaymentIntent and SetupIntent structs in the codebase. Consider using serde's flatten attribute to combine common fields into a single struct. The issue suggests creating a common struct or using flatten. Review the current implementation to identify all common fields.