jupyterlab/jupyterlab

Trusting notebook in RTC mode leads to `File Changed` dialog

Open

#14,347 opened on Apr 8, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (13,454 stars) (2,937 forks)batch import
bughelp wantedtag:Real Time Collaboration

Description

Description

Regardless of fixes in https://github.com/jupyterlab/jupyterlab/pull/14345 the trust status is not set for empty (1 code cell) notebooks on RTC, and an attempt to Trust notebook ends up with File Changed dialog.

Reproduce

trust-rtc-itneraction

  1. Spin up RTC setup on binder
  2. Open command palette
  3. Choose "Trust Notebook"
  4. Click Trust
  5. See File Changed dialog

Expected behavior

  • whatever causes the trusted metadata to be lost on code cells when RTC is active gets ironed out.
  • trusting notebook works the same on RTC as it works locally, without dialog.

Context

  • Browser and version: latest Chromium family
  • JupyterLab version: 4.0.0b1

Contributor guide

Tech stack
typescript
Domain
full stack
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of JupyterLab trust mechanism
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the trust status handling in RTC mode. Look at PR #14345 and the associated changes. Examine how trusted metadata is propagated in real time collaboration. The bug occurs specifically for notebooks with one code cell. Check the logic that sets trust status on notebook load and after trust action.
Trusting notebook in RTC mode leads to `File Changed` dialog · jupyterlab/jupyterlab#14347 | Good First Issue