jupyterhub/repo2docker

Always convert line endings in `postBuild` to unix

Open

#263 opened on Mar 15, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (358 forks)batch import
enhancementgood first issuehacktoberfesthelp wanted

Repository metrics

Stars
 (1,544 stars)
PR merge metrics
 (Avg merge 17h 41m) (2 merged PRs in 30d)

Description

We should filter/convert the line endings in postBuild as that seems to cause problems (see https://github.com/jupyter/repo2docker/issues/237#issuecomment-373446647)

Is there a docker option to have it convert line endings on COPY or do we have to convert it before copying or add a tool like dos2unix to the container?

Contributor guide

Research direction
Investigate how to handle line ending conversion in Dockerfiles, e.g., using dos2unix in postBuild or Docker COPY options.
Tech stack
pythondocker
Domain
devops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65