jupyterhub/repo2docker

Always convert line endings in `postBuild` to unix

Open

#263 opened on Mar 15, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (1,544 stars) (358 forks)batch import
enhancementgood first issuehacktoberfesthelp wanted

Description

We should filter/convert the line endings in postBuild as that seems to cause problems (see https://github.com/jupyter/repo2docker/issues/237#issuecomment-373446647)

Is there a docker option to have it convert line endings on COPY or do we have to convert it before copying or add a tool like dos2unix to the container?

Contributor guide

Tech stack
pythondocker
Domain
backenddevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Knowledge of DockerLine ending concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the linked comment in issue #237 to understand the exact problem. Check if Docker has a line ending conversion option during COPY. If not, explore converting the postBuild file before copying it into the container or adding a tool like dos2unix. The solution should ensure Unix line endings are used consistently.