(SSH) error messages misleading

Open Beginner friendly
#3,335 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
go
Domain
backend

Research direction

Start in hscontrol/policy/v2/types.go around line 51 and inspect the ErrSSH objects and their messages. Confirm that the reported policy parsing error comes from this SSH-related set of errors. Done means the ErrSSH messages clearly reference SSH, with the existing behavior otherwise unchanged.

Written by the indexing model from the issue text.

Description

I was just upgrading to 0.29.1 and hit the error

headscale | Error: initializing: creating new headscale: init state: initializing policy manager: parsing policy: users must be specified

After some time I found out that the SSH users must be specified. My suggestion would be to have all the ErrSSH objects reference "ssh" somehow in the message to make that fact more clear.

https://github.com/juanfont/headscale/blob/33a65052c9aa0bd492b937408b0cf4e618a1bdc8/hscontrol/policy/v2/types.go#L51

Dominant language
Go
Stars
44k
Forks
2.6k
Avg merge
3d 10h
Merged PRs (30d)
15

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from juanfont/headscale

All issues in juanfont/headscale

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.