jsx-eslint/eslint-plugin-react

no-unused-prop-types cannot detect unused property

Open

#880 opened on Oct 3, 2016

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (2,797 forks)batch import
bughelp wanted

Repository metrics

Stars
 (8,630 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

const Comp = (props) => <div className={props.nested.className}>{props.nested.text}</div>;
Comp.propTypes = {
    nested: React.PropTypes.object.isRequired,
    text: React.PropTypes.string.isRequired
};

Property text should be marked as unused. Rule configuration: "react/no-unused-prop-types": ["error", {skipShapeProps: true}].

Contributor guide

Research direction
Investigate how the rule 'no unused prop types' traverses propTypes and identify why skipShapeProps option causes it to miss unused nested prop types.
Tech stack
javascriptreact
Domain
frontendtoolingdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLintReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60