jsx-eslint/eslint-plugin-react

no-direct-mutation-state on references

Open

#747 opened on Aug 7, 2016

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)JavaScript (2,731 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (9,293 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently no-direct-mutation-state doesn't seem to support hunting down (even simple cases) where a reference to this.state is being used. Luckily I caught my co-workers bug while doing code review but it would be pretty sweet if the rule could detect this case too.

const { product } = this.state;
product.name = name;

I've never written an eslint rule before so I have no clue if this is even possible, if it is, please let me know and I might give it a stab when I have some more free time.

Contributor guide

Research direction
Inspect the rule's source code in eslint plugin react to understand how it currently detects direct state mutations. Then extend it to also detect mutations via references like `const { product } = this.state; product.name = name;`.
Tech stack
javascriptreact
Domain
frontendtooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLint rule development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65