jsx-eslint/eslint-plugin-react

Rule proposal: disallow onFocusIn and onFocusOut on DOM element tags

Open

#714 opened on Jul 26, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,797 forks)batch import
help wantednew rule

Repository metrics

Stars
 (8,630 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

React will issue a warning in dev if you use onFocusIn or onFocusOut.

https://github.com/facebook/react/blob/85dcbf83/src/renderers/dom/shared/ReactDOMComponent.js#L196-L200

This should be easy enough to enforce for most cases with a linter rule.

Bad:

<div onFocusIn={() => {}} />

<div onFocusOut={() => {}} />

Good:

<div onFocus={() => {}} />

<div onBlur={() => {}} />

Contributor guide

Research direction
Study the eslint plugin react source code, particularly an existing rule like 'no onchange readonly'. Create a new rule file for 'no focus in out', write tests matching the bad and good examples, add documentation, and register the rule in the plugin's index.
Tech stack
javascriptreact
Domain
frontendweb dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitESLintJavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75