jsx-eslint/eslint-plugin-react

Rule proposal: check constructor params for props and context

Open

#626 opened on Jun 7, 2016

View on GitHub
 (7 comments) (5 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
help wantednew rule

Description

This rule would check for:

class X extends Component {
  constructor(props, context) {
    super(props, context);
  }
}

React is lenient, so constructor() { super(); } works, so this is just a stylistic preference.

Contributor guide

Tech stack
javascriptreact
Domain
frontenddeveloper experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptReactESLint rule development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine existing rules in the eslint plugin react repository (e.g., rules/no direct mutation state) for implementation patterns. Use the ESLint custom rule documentation to create a rule that checks the number and names of parameters in constructor of React components extending Component. The rule should be configurable for strict checking of props and context parameters. Consider edge cases like PureComponent or using constructor without super.