jsx-eslint/eslint-plugin-react

[Bug]: react/jsx-no-leaked-render reports error on boolean values and tries to convert them

Open

#3908 opened on Mar 21, 2025

View on GitHub
 (2 comments) (5 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
enhancementhelp wantedtypescript

Description

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

Using following setup:

'react/jsx-no-leaked-render': ['error', { validStrategies: ['ternary', 'coerce'] }]

Image

The code reports error even though emptyCollection is already boolean value. I understand that the plugin does not take into account actual types that TS provides.

Running lint command reports an issue unless I convert the code to this 👇

Image

Is there a way to prevent this from being "fixed" since it's already a boolean value?

Expected Behavior

eslint-plugin-react version

v7.37.4

eslint version

v9.18.0

node version

v22.13.0

Contributor guide

Tech stack
javascriptreact
Domain
frontendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ESLint plugin developmentReact JSXAST understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the rule implementation at `lib/rules/jsx no leaked render.js`. Review the test file for this rule (likely `tests/lib/rules/jsx no leaked render.js`) to understand current test cases. The core issue is that the rule incorrectly flags boolean variables when using the ternary or coerce strategy. Determine if the rule should rely on TypeScript type annotations (using `@typescript eslint/parser`) or if a simpler heuristic (e.g., checking that the expression is a boolean literal or `typeof x === 'boolean'`) can be applied. Check the comments in issue #3908 for any maintainer suggestions.