jsx-eslint/eslint-plugin-react

[Bug]: `hook-use-state` suggested fix should update all reference

Open

#3810 opened on Aug 31, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
enhancementhelp wanted

Description

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

The current fix suggested is to simply replace the variable, This isn't smart enough

It should update all references

https://github.com/user-attachments/assets/92187480-3b65-4667-a94b-66c8670de283

Expected Behavior

This is a custom react-hook-use-state rule I wrote. Before this, I didn’t know the existence of react/hook-use-state

it's smart enough

https://github.com/user-attachments/assets/196c5324-b1f8-41d7-8f5a-efd2c8342508

I have implemented almost all the functions of react/hook-use-state, but the logic is simpler

I checked the source code of hook-use-state, it is very complicated, and I can't modify it

I hope react/hook-use-state can also achieve this function by someone

eslint-plugin-react version

v7.35.0

eslint version

v9.9.1

node version

v20

Contributor guide

Tech stack
javascriptreact
Domain
frontendtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ESLint rule developmentASTReact hooks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the source code of the `react/hook use state` rule in `lib/rules/hook use state.js`. Understand the current fix mechanism and why it does not update all references. Compare with similar rules that handle multiple references. The goal is to modify the fix function to traverse all usages of the variable and apply the rename everywhere. Also review the rule's test file to understand expected behavior.