jsx-eslint/eslint-plugin-react

[Bug]: Not working with @typescript-eslint/parser v8

Open

#3792 opened on Aug 1, 2024

View on GitHub
 (4 comments) (7 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
help wantedtypescript

Description

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

Due to : https://github.com/typescript-eslint/typescript-eslint/pull/8933

accessing "typeParameters" will now be undefined.

It needs to be changed to "typeArguments" (and the other deprecations in the Pr linked above).

Expected Behavior

The result is that eslint-pugin-react doesn't find any declared props in a typescript project.

I see there is a PR to fix this: https://github.com/jsx-eslint/eslint-plugin-react/pull/3788 but it is about the deprecations, not the fact that eslint-plugin-react just stops working without any indication why (no errors from npm etc.)

eslint-plugin-react version

7.35.0

eslint version

v8.57.0

node version

v22

Contributor guide

Tech stack
typescriptjavascriptreactnodejs
Domain
frontendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptReactTypeScriptESLint plugin basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is caused by a breaking change in @typescript eslint/parser v8 where 'typeParameters' was renamed to 'typeArguments'. The fix involves finding all usages of 'typeParameters' in the eslint plugin react codebase (e.g., in rule implementations) and replacing them with 'typeArguments'. The linked PR #3788 addresses other deprecations but not this specific breakage, so a new PR should focus solely on this rename. After making changes, test with @typescript eslint/parser v8 to ensure the plugin works again. Consult the repository's contributing guidelines and existing tests for integration.