jsx-eslint/eslint-plugin-react

[Bug]: `react/prop-types` false positive when component is a value of capitalized property in class

Open

#3534 opened on Feb 21, 2023

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
bughelp wanted

Description

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

Weird error: image

import React from 'react';

class SomeComponent {
	column = {
		Cell: ({ original }: { original: string }) => <span>{original === 'bla' ? 'bla' : 'bla'}</span>,
	};
}

error    'original' is missing in props validation  react/prop-types

eslint myfile.tsx

Expected Behavior

Not to throw error

When I change Cell to cell - the error is gone. When I avoid using destructuring - the error is also gone.

eslint-plugin-react version

v7.32.2

eslint version

v8.34.0

node version

v18.14.1

Contributor guide

Tech stack
javascripttypescriptreact
Domain
frontendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ESLint plugin architectureReact prop types ruleTypeScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Start by examining the `react/prop types` rule implementation in `lib/rules/prop types.js`. Look for how the rule identifies React components and validates props. The bug occurs when a component is assigned to a capitalized property (e.g., `Cell`) in a class instance, causing a false positive. Investigate the logic that determines whether a variable is a component vs. a regular prop. Check the issue comments for any maintainer hints or related PRs. Focus on the expression handler and see if the capitalization triggers an incorrect assumption that the value is a component.