jsx-eslint/eslint-plugin-react

`react/no-unstable-nested-components` does not allow ignoring only object properties

Open

#3,482 opened on Nov 4, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,797 forks)batch import
bughelp wanted

Repository metrics

Stars
 (8,630 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I would like to keep this rule active but disable it for object properties, I have this:

function MyComponent() {
  return (
    <p>
      {intl.formatMessage(messages.allSelected, {
        size: selectedEvents.size,
        b: chunks => <b>{chunks}</b>, // <-- report error here without `allowAsProps`
      })}
    </p>
  );
}

But adding the allowAsProps: true option allows me to do things like this:

<Dropdown
  Trigger={({ onClick }) => ( // <-- don't report error here with `allowAsProps`
    <button type="button" onClick={onClick}>
      Bla bla
      <span className="caret" />
    </button>
  )}
>
  {/* ... */}
</Dropdown>

Contributor guide

Research direction
Inspect the implementation of the `no unstable nested components` rule in the ESLint plugin for React. Understand how the current `allowAsProps` option works. Design a new option (e.g., `allowObjectProperties`) to permit nested components created inside object literals without triggering the rule. Modify the rule logic and update tests and documentation.
Tech stack
javascripttypescriptreact
Domain
frontendtooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReactESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50