jsx-eslint/eslint-plugin-react

Declaring context type on class component breaks static-property-placement

Open

#3467 opened on Oct 19, 2022

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
help wanted

Description

Hi,

After upgrading eslint-plugin-react from 7.31.8 to 7.31.9+ (#2581), it started breaking the declare keyword on context in TypeScript:

Not sure what is the mitigation in this case

Contributor guide

Tech stack
typescriptreact
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScriptESLint plugin developmentReact class components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the changes introduced in PR #2581 that caused the regression. Examine the static property placement rule implementation in eslint plugin react, specifically how it handles context type declarations on class components. Look for any TypeScript specific logic that might be mishandling the `declare` keyword. Consider writing a test case that reproduces the issue.