jsx-eslint/eslint-plugin-react

[react/require-default-props] False positive with React.forwardRef

Open

#2856 opened on Nov 13, 2020

View on GitHub
 (29 comments) (14 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
help wanted

Description

The react/require-default-props rule configured with ignoreFunctionalComponents: true produces false positives for functional components that use React.forwardRef, like the following:

import React from "react"
import PropTypes from "prop-types"

const Demo = React.forwardRef((props, ref) => {
  const { text } = props
  return <div ref={ref}>{text}</div>
})

Demo.propTypes = {
  // Error: propType "text" is not required, but has no corresponding defaultProps declaration
  text: PropTypes.string,
}

export default Demo

Here are two CodeSandbox links demonstrating the problem with both .jsx and .tsx files:

Run yarn lint to reproduce.

I would expect components built with React.forwardRef to be considered functional components and be ignored when ignoreFunctionalComponents is true.

Contributor guide

Tech stack
javascriptreacttypescriptnodejs
Domain
frontendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactESLint plugin internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the rule's source code in `lib/rules/require default props.js` and identify how it detects functional components. The utility function likely needs to recognize `React.forwardRef` and `React.memo` wrappers. The discussion suggests referencing existing PRs that attempted similar fixes. Write tests for both JSX and TSX cases to ensure the rule works with `ignoreFunctionalComponents: true`. Use the provided CodeSandbox links as reproduction cases.