jsx-eslint/eslint-plugin-react

Ignore nested components in no-multi-comp

Open

#2842 opened on Oct 24, 2020

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
help wanted

Description

I don’t think react/no-multi-comp should trigger on nested components or should have an option to disable it. A practical example:

import { FormattedMessage } from 'react-intl';

export function App() {
  return (
    <FormattedMessage
      values={{
        link:
          // The next line triggers react/no-multi-comp
          (text: string) => <a>{text}</a>,
      }}
    />
  );
}

I suggest to add an option ignoreNested which ignores any components that aren’t declared as part of the Program node body.

Contributor guide

Tech stack
javascriptreact
Domain
frontendtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ESLint plugin developmentAST concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
To implement the request, modify the rule in src/rules/no multi comp.js to detect whether a component is declared inside another component (i.e., not at the Program body level). Add an option named "ignoreNested" (boolean) that skips components whose parent node is not the Program. Ensure the option is documented in the rule's schema and README. Test with the given example to confirm nested components are ignored.