jsx-eslint/eslint-plugin-react

Ignore nested components in no-multi-comp

Open

#2,842 opened on Oct 24, 2020

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (2,797 forks)batch import
help wanted

Repository metrics

Stars
 (8,630 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I don’t think react/no-multi-comp should trigger on nested components or should have an option to disable it. A practical example:

import { FormattedMessage } from 'react-intl';

export function App() {
  return (
    <FormattedMessage
      values={{
        link:
          // The next line triggers react/no-multi-comp
          (text: string) => <a>{text}</a>,
      }}
    />
  );
}

I suggest to add an option ignoreNested which ignores any components that aren’t declared as part of the Program node body.

Contributor guide

Research direction
Examine the no multi comp rule in the repository and add an 'ignoreNested' option that skips components not declared as direct children of Program node.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLint plugin developmentJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70