jsx-eslint/eslint-plugin-react

react/jsx-no-useless-fragment false positive

Open

#2584 opened on Mar 3, 2020

View on GitHub
 (15 comments) (23 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
help wanted

Description

There's a false positive on the rule with forwarded children. Use cases are pretty rare but still exist. Without a fragment around the children, code breaks at runtime

const HollowComponent = ({ children }) => {
  // some logic here
  return <>{children}</>; // doesn't pass the rule
}

example: https://codesandbox.io/s/icy-lake-ri3uo

Temporary fix is to disable rule for this line but it would be nicer if this rule let this kind of Fragment use possible.

Contributor guide

Tech stack
javascriptreact
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React basicsESLint rule structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the rule `jsx no useless fragment` in `lib/rules/jsx no useless fragment.js`. The issue reports a false positive when a fragment wraps `{children}` that could be multiple elements. Examine the current logic and the provided codesandbox example. Consider adding an option to allow fragments that serve as a wrapper for forwarded children, or update the rule to recognize this pattern. Review existing tests and comments in the issue for additional context.