jsx-eslint/eslint-plugin-react

Don't warn about react/jsx-no-target-blank when referrerPolicy is used

Open

#2398 opened on Sep 2, 2019

View on GitHub
 (7 comments) (1 reaction) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
enhancementhelp wanted

Description

We have in our code:

<a rel="noopener" referrerPolicy="no-referrer" target="_blank" href={fooURL}>foo</a>

But react/jsx-no-target-blank is complaining about it with:

 Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener  react/jsx-no-target-blank

Isn't it the same to have rel="noopener" and referrerPolicy="no-referrer" as having rel="noopener noreferrer"?

eslint-plugin-react@7.14.3

Contributor guide

Tech stack
javascriptreact
Domain
securitydeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with ESLint plugin structureUnderstanding of React JSXKnowledge of security implications of target=' blank'
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review the implementation of the jsx no target blank rule in lib/rules/jsx no target blank.js. Examine the existing logic that checks for rel attributes and consider how referrerPolicy attribute should be treated as equivalent to rel='noopener noreferrer'. Check the test file for existing test cases and add new ones. Look at comments in the issue for any suggested approach.