jsx-eslint/eslint-plugin-react

prefer-stateless-function should not check a .d.ts for a Stateful Component

Open

#2,296 opened on May 31, 2019

View on GitHubContributor guide
 (3 comments) (2 reactions) (0 assignees)JavaScript (2,731 forks)batch import
bughelp wantedtypescript

Repository metrics

Stars
 (9,293 stars)
PR merge metrics
 (PR metrics pending)

Description

Imagine that we have a stateful react component and is about to creating a declaration file d.ts for the .js/.jsx file.

declare class StateCom extends React.Component<Props> {}
export default StateCom;

and error/warning occurs that: Component should be written as a pure function eslint(react/prefer-stateless-function)

How can we handle this since the component is a truly Component with state instead of a functional component?

Contributor guide

Research direction
Examine the rule logic for prefer stateless function and determine why it processes .d.ts files. Add a check to skip declaration files or modify the rule to ignore components declared as classes in .d.ts.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLintReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70