jsx-eslint/eslint-plugin-react
View on GitHub'no-unused-prop-types' breaks when using destructuring in jsx attributes
Open
#2,222 opened on Mar 29, 2019
bughelp wanted
Repository metrics
- Stars
- (8,630 stars)
- PR merge metrics
- (No merged PRs in 30d)
Description
I was scratching my head over why no-unused-prop-types didn't trigger at all for some of my components, and after some experimentation it turns out it happens whenever I use destructuring in jsx attributes:
const DumbComponent = props => {
const someObj = { value: 619 };
return (
<SomeOtherComp {...someObj} />
);
};
DumbComponent.propTypes = {
unused_prop: PropTypes.string // doesn't trigger
};
but
const DumbComponent = props => {
const someObj = { value: 619 };
return (
<SomeOtherComp value={someObj.value} />
);
};
DumbComponent.propTypes = {
unused_prop: PropTypes.string // triggers
};