jsx-eslint/eslint-plugin-react

Rule proposal: prevent object literal spreads

Open

#2,217 opened on Mar 26, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,797 forks)batch import
help wantednew rule

Repository metrics

Stars
 (8,630 stars)
PR merge metrics
 (Avg merge 1d 17h) (3 merged PRs in 30d)

Description

In JSX it's possible to write:

<Foo {...{a: 1, b: 2}} />

instead of

<Foo a={1} b={2} />

The former is valid JSX but (to React eyes) hard to read. It would be good to lint against it (it may be autofixable too, not sure about edge cases).

Contributor guide

Research direction
Implement a new ESLint rule that detects object literal spreads in JSX (e.g., `{...{a:1}}`) and suggests autofix to individual props. Study existing rules in eslint plugin react for patterns and AST node types.
Tech stack
javascriptreactnodejs
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80