jsx-eslint/eslint-plugin-react

Unexpected errors if Flow types were defined

Open

#2173 opened on Feb 21, 2019

View on GitHub
 (6 comments) (4 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
bugflowhelp wanted

Description

Hello! I've updated from eslint-plugin-react@7.7.0 to eslint-plugin-react@7.12.4 and I got some new specific errors. I got unexpected react/no-unused-prop-types error on 5 and 6 lines in the next code listing.

// @flow
import React from 'react';

export type ChildComponentProps = {
    value: string,
    name: string
};

export const ParentComponent = ({arrayOfSmth}: Object) => {
    return (
        <div>
            {arrayOfSmth.map(({value, name}: ChildComponentProps) => {
                return (
                    <span>
                        {name ? value : <Text>{name}</Text>}
                    </span>
                );
            })}
        </div>
    );
};

5:12  error    'value' PropType is defined but prop is never used  react/no-unused-prop-types
6:11  error    'name' PropType is defined but prop is never used   react/no-unused-prop-types

Is it expected behavior for my case?

Contributor guide

Tech stack
javascriptreact
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of FlowUnderstanding of ESLint rulesReact prop types
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the `react/no unused prop types` rule implementation in `lib/rules/no unused prop types.js` to understand how it processes Flow type annotations. Determine if the rule incorrectly flags Flow type destructuring as unused prop types. Check if the rule has a specific check for Flow type imports or type aliases. Review any existing comments on the issue for potential fixes or workarounds.