jsx-eslint/eslint-plugin-react

The react/display-name rule assumes displayNames are set that are not

Open

#2,150 opened on Feb 2, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (8,630 stars) (2,797 forks)batch import
help wantedquestion

Description

From what I can tell, @babel/plugin-transform-react-display-name only adds display names for components created with React.createClass or createReactClass, yet the react/display-name rule assumes the transpiler sets a displayName for components that extend React.Component and functional components.

If the transpiler referenced in the docs is referring to some other babel plugin, the docs should be updated to link to that plugin.

Contributor guide

Tech stack
javascriptreact
Domain
frontendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic React knowledgeunderstanding of ESLint pluginsfamiliarity with Babel transpilation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the behavior of @babel/plugin transform react display name to confirm whether it only adds display names for components created with React.createClass or createReactClass. Check the eslint plugin react documentation and source code for the react/display name rule to see where the assumption is made. Consider updating the documentation to clarify the transpiler reference or adjusting the rule to not assume display names are set by the transpiler.
The react/display-name rule assumes displayNames are set that are not · jsx-eslint/eslint-plugin-react#2150 | Good First Issue